Re: [PATCH v1 1/2] coresight: Add remote etm support

[Jinlong Mao]

On 11/8/2023 7:19 PM, James Clark wrote:
> On 07/11/2023 06:09, Mao Jinlong wrote:
> > Add support for ETM trace collection on remote processor using
> > coreSight framework.
> >
> > Signed-off-by: Mao Jinlong <quic_jinlmao@xxxxxxxxxxx>
> > ---
> >   drivers/hwtracing/coresight/Kconfig           |   9 +
> >   drivers/hwtracing/coresight/Makefile          |   1 +
> >   drivers/hwtracing/coresight/coresight-core.c  |   3 +
> >   drivers/hwtracing/coresight/coresight-qmi.h   | 109 ++++++
> >   .../coresight/coresight-remote-etm.c          | 325 ++++++++++++++++++
> >   include/linux/coresight.h                     |   1 +
> >   6 files changed, 448 insertions(+)
> >   create mode 100644 drivers/hwtracing/coresight/coresight-qmi.h
> >   create mode 100644 drivers/hwtracing/coresight/coresight-remote-etm.c
> >
> > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
> > index 06f0a7594169..425886ab7401 100644
> > --- a/drivers/hwtracing/coresight/Kconfig
> > +++ b/drivers/hwtracing/coresight/Kconfig
> > @@ -247,4 +247,13 @@ config CORESIGHT_DUMMY
> >   
> >   	  To compile this driver as a module, choose M here: the module will be
> >   	  called coresight-dummy.
> > +
> > +config CORESIGHT_REMOTE_ETM
> > +	tristate "Remote processor ETM trace support"
> > +	select QCOM_QMI_HELPERS
> > +	help
> > +	  Enables support for ETM trace collection on remote processor using
> > +	  CoreSight framework. Enabling this will allow turning on ETM
> > +	  tracing on remote processor via sysfs by configuring the required
> > +	  CoreSight components.
> >   endif
> > diff --git a/drivers/hwtracing/coresight/Makefile b/drivers/hwtracing/coresight/Makefile
> > index 995d3b2c76df..a5283cab0bc0 100644
> > --- a/drivers/hwtracing/coresight/Makefile
> > +++ b/drivers/hwtracing/coresight/Makefile
> > @@ -29,5 +29,6 @@ obj-$(CONFIG_CORESIGHT_TPDM) += coresight-tpdm.o
> >   obj-$(CONFIG_CORESIGHT_TPDA) += coresight-tpda.o
> >   coresight-cti-y := coresight-cti-core.o	coresight-cti-platform.o \
> >   		   coresight-cti-sysfs.o
> > +obj-$(CONFIG_CORESIGHT_REMOTE_ETM) += coresight-remote-etm.o
> >   obj-$(CONFIG_ULTRASOC_SMB) += ultrasoc-smb.o
> >   obj-$(CONFIG_CORESIGHT_DUMMY) += coresight-dummy.o
> > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
> > index d7f0e231feb9..f365a3899821 100644
> > --- a/drivers/hwtracing/coresight/coresight-core.c
> > +++ b/drivers/hwtracing/coresight/coresight-core.c
> > @@ -1094,6 +1094,7 @@ static int coresight_validate_source(struct coresight_device *csdev,
> >   	if (subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_PROC &&
> >   	    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE &&
> >   	    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM &&
> > +	    subtype != CORESIGHT_DEV_SUBTYPE_SOURCE_REMOTE_PROC &&
......
> +{
> +	return platform_driver_register(&remote_etm_driver);
> +}
> +module_init(remote_etm_init);
> +
> +void __exit remote_etm_exit(void)
> +{
> +	platform_driver_unregister(&remote_etm_driver);
> +}
> +module_exit(remote_etm_exit);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("CoreSight Remote ETM driver");
> diff --git a/include/linux/coresight.h b/include/linux/coresight.h
> index a4cb7dd6ca23..f0a947a61680 100644
> --- a/include/linux/coresight.h
> +++ b/include/linux/coresight.h
> @@ -65,6 +65,7 @@ enum coresight_dev_subtype_source {
>   	CORESIGHT_DEV_SUBTYPE_SOURCE_BUS,
>   	CORESIGHT_DEV_SUBTYPE_SOURCE_SOFTWARE,
>   	CORESIGHT_DEV_SUBTYPE_SOURCE_TPDM,
> +	CORESIGHT_DEV_SUBTYPE_SOURCE_REMOTE_PROC,
>   	CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS,
>   };
>   
Thanks for the review. I will check the comments and address your 
comments in next version.

Thanks
Jinlong Mao