Re: [PATCH v3 06/20] riscv: add ISA extension parsing for vector crypto

From: Conor Dooley
Date: Thu Nov 09 2023 - 02:54:48 EST


On Thu, Nov 09, 2023 at 07:44:46AM +0000, Conor Dooley wrote:
> On Thu, Nov 09, 2023 at 10:58:41AM +0800, Jerry Shih wrote:
> > On Nov 7, 2023, at 18:55, Clément Léger <cleger@xxxxxxxxxxxx> wrote:
> > > +static const unsigned int riscv_zvknhb_exts[] = {
> > > + RISCV_ISA_EXT_ZVKNHA
> > > +};
> > > +
> >
> > > + __RISCV_ISA_EXT_SUPERSET(zvknhb, RISCV_ISA_EXT_ZVKNHB, riscv_zvknhb_exts),
> > > + __RISCV_ISA_EXT_BUNDLE(zvks, riscv_zvks_bundled_exts),
> >
> > The Zvknha and Zvknhb are exclusive. It's not the superset relationship.
> >
> > Please check:
> > https://github.com/riscv/riscv-crypto/issues/364#issuecomment-1726782096
>
> You got a response to this on the previous version, but didn't engage
> with it:
> https://lore.kernel.org/all/c64d9ddb-edbd-4c8f-b56f-1b90d82100b7@xxxxxxxxxxxx/#t

Ahh, I now see what that happened. Your mailer is broken and puts the
message-id of what you are replying to in the In-Reply-To and Reply-To
headers. The former is correct, the latter is bogus & means you don't even
get delivered the response.

Attachment: signature.asc
Description: PGP signature