Re: [PATCH v8 00/12] add support MDP3 on MT8195 platform

From: nicolas
Date: Thu Nov 09 2023 - 12:15:03 EST

Hi Angelo,

Le lundi 06 novembre 2023 à 13:45 +0100, AngeloGioacchino Del Regno a
écrit :
> Il 30/10/23 11:06, Moudy Ho ha scritto:
> > Changes since v7:
> > - Rebase on linux-next.
> > - Dependent dtsi files:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=797543
> > - Dependent bindings:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=797555
> > - Patch [9/12] has made corresponding adjustments in response to the changes in
> > the compatible name of the PAD component in DTSI and binding.
> > - Adding WROT compatible name in the MDP driver's of_match_table in [9/12] to
> > avoid deactivating 'pm_runtime_*' functions.
> >
>
> On MT8195 Cherry Tomato Chromebook, whole series is
>
> Tested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Would you mind dropping a short description of what your test consist ?
Which userspace have been used, did you cover all the pixel formats
combination ? Did you test scaling, rotation, etc. ?

Nicolas

>
> > Changes since v6:
> > - Rebase on v6.6-rc5.
> > - Dependent dtsi files:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=792079
> > - Dependent bindings:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=792477
> > - Move the patch that fixes compile warnings from this series and
> > create a separate standalone patch.
> >
> > Changes since v5:
> > - Rebase on v6.6-rc2.
> > - Dependent dtsi files:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=786511
> > - Dependent bindings:
> > https://patchwork.kernel.org/project/linux-mediatek/list/?series=786520
> > - Integrate MMSY/MUTEX structure in "mdp_probe".
> > - Fix the build warnings that were detected by the linux-media
> > build scripts tool.
> >
> > Changes since v4:
> > - Rebase on v6.6-rc1
> > - Remove any unnecessary DTS settings.
> > - Adjust the usage of MOD and clock in blending components.
> >
> > Changes since v3:
> > - Depend on :
> > [1] https://patchwork.kernel.org/project/linux-media/list/?series=719841
> > - Suggested by Krzysztof, integrating all newly added bindings for
> > the mt8195 MDP3 into the file "mediatek,mt8195-mdp3.yaml".
> > - Revise MDP3 nodes with generic names.
> >
> > Changes since v2:
> > - Depend on :
> > [1] MMSYS/MUTEX: https://patchwork.kernel.org/project/linux-mediatek/list/?series=711592
> > [2] MDP3: https://patchwork.kernel.org/project/linux-mediatek/list/?series=711618
> > - Suggested by Rob to revise MDP3 bindings to pass dtbs check
> > - Add parallel paths feature.
> > - Add blended components settings.
> >
> > Changes since v1:
> > - Depend on :
> > [1] MDP3 : https://patchwork.kernel.org/project/linux-mediatek/list/?series=698872
> > [2] MMSYS/MUTEX: https://patchwork.kernel.org/project/linux-mediatek/list/?series=684959
> > - Fix compilation failure due to use of undeclared identifier in file "mtk-mdp3-cmdq.c"
> >
> > Hello,
> >
> > This patch is used to add support for MDP3 on the MT8195 platform that
> > contains more picture quality components, and can arrange more pipelines
> > through two sets of MMSYS and MUTEX respectively.
> >
> > Moudy Ho (12):
> > media: platform: mtk-mdp3: add support second sets of MMSYS
> > media: platform: mtk-mdp3: add support second sets of MUTEX
> > media: platform: mtk-mdp3: introduce more pipelines from MT8195
> > media: platform: mtk-mdp3: introduce more MDP3 components
> > media: platform: mtk-mdp3: add checks for dummy components
> > media: platform: mtk-mdp3: avoid multiple driver registrations
> > media: platform: mtk-mdp3: extend GCE event waiting in RDMA and WROT
> > media: platform: mtk-mdp3: add support for blending multiple
> > components
> > media: platform: mtk-mdp3: add mt8195 platform configuration
> > media: platform: mtk-mdp3: add mt8195 shared memory configurations
> > media: platform: mtk-mdp3: add mt8195 MDP3 component settings
> > media: platform: mtk-mdp3: add support for parallel pipe to improve
> > FPS
> >
> > .../platform/mediatek/mdp3/mdp_cfg_data.c | 729 +++++++++++++-
> > .../platform/mediatek/mdp3/mdp_reg_aal.h | 25 +
> > .../platform/mediatek/mdp3/mdp_reg_color.h | 31 +
> > .../media/platform/mediatek/mdp3/mdp_reg_fg.h | 23 +
> > .../platform/mediatek/mdp3/mdp_reg_hdr.h | 31 +
> > .../platform/mediatek/mdp3/mdp_reg_merge.h | 25 +
> > .../platform/mediatek/mdp3/mdp_reg_ovl.h | 25 +
> > .../platform/mediatek/mdp3/mdp_reg_pad.h | 21 +
> > .../platform/mediatek/mdp3/mdp_reg_rdma.h | 24 +
> > .../platform/mediatek/mdp3/mdp_reg_rsz.h | 2 +
> > .../platform/mediatek/mdp3/mdp_reg_tdshp.h | 34 +
> > .../platform/mediatek/mdp3/mdp_reg_wrot.h | 8 +
> > .../platform/mediatek/mdp3/mdp_sm_mt8195.h | 283 ++++++
> > .../platform/mediatek/mdp3/mtk-img-ipi.h | 4 +
> > .../platform/mediatek/mdp3/mtk-mdp3-cfg.h | 2 +
> > .../platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 440 +++++++--
> > .../platform/mediatek/mdp3/mtk-mdp3-cmdq.h | 1 +
> > .../platform/mediatek/mdp3/mtk-mdp3-comp.c | 895 +++++++++++++++++-
> > .../platform/mediatek/mdp3/mtk-mdp3-comp.h | 93 +-
> > .../platform/mediatek/mdp3/mtk-mdp3-core.c | 139 ++-
> > .../platform/mediatek/mdp3/mtk-mdp3-core.h | 50 +-
> > .../platform/mediatek/mdp3/mtk-mdp3-m2m.c | 15 +
> > .../platform/mediatek/mdp3/mtk-mdp3-regs.c | 18 +
> > .../platform/mediatek/mdp3/mtk-mdp3-regs.h | 1 +
> > .../platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 +-
> > 25 files changed, 2744 insertions(+), 178 deletions(-)
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_aal.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_color.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_fg.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_hdr.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_merge.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_ovl.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_pad.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_reg_tdshp.h
> > create mode 100644 drivers/media/platform/mediatek/mdp3/mdp_sm_mt8195.h
> >
>