Re: [PATCH v7 10/24] x86/resctrl: Allocate the cleanest CLOSID by searching closid_num_dirty_rmid

[Reinette Chatre]

Hi James,

On 10/25/2023 11:03 AM, James Morse wrote:
> MPAM's PMG bits extend its PARTID space, meaning the same PMG value can be
> used for different control groups.
> 
> This means once a CLOSID is allocated, all its monitoring ids may still be
> dirty, and held in limbo.
> 
> Instead of allocating the first free CLOSID, on architectures where
> CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is enabled, search
> closid_num_dirty_rmid[] to find the cleanest CLOSID.
> 
> The CLOSID found is returned to closid_alloc() for the free list
> to be updated.
> 
> Tested-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>
> Tested-by: Peter Newman <peternewman@xxxxxxxxxx>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxx>
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
> Signed-off-by: James Morse <james.morse@xxxxxxx>
> ---
> Changes since v4:
>  * Dropped stale section from comment
> 
> Changes since v5:
>  * Renamed some variables.
> 
> No changes since v6

I use these patch changelogs to determine if I need to look at a
patch for which I already provided a review tag. At first this
patch appears to not deserve a second glance because I already provided a
review tag and the above states "No changes since v6". Unfortunately
this is false. I counted four changes. Now I cannot trust these
"No changes since v6" and I need to dig out v6 to diff patches I already
reviewed to determine if I need to look at them again. False patch
changelogs make a patch series harder to review.

Reinette