Re: [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id

[zhangqing]

在 2023/11/9 18:24, Krzysztof Kozlowski 写道:
> On 09/11/2023 11:05, zhangqing wrote:
> > 在 2023/11/9 17:21, Krzysztof Kozlowski 写道:
> > > On 09/11/2023 09:06, zhangqing wrote:
> > > > 在 2023/11/9 15:29, Conor Dooley 写道:
> > > > > On Thu, Nov 09, 2023 at 02:27:38PM +0800, zhangqing wrote:
> > > > > > Hi:
> > > > > >
> > > > > > 在 2023/11/8 20:01, Conor Dooley 写道:
> > > > > > > On Wed, Nov 08, 2023 at 02:18:21PM +0800, Elaine Zhang wrote:
> > > > > > > > export PCLK_VO1GRF for DT.
> > > > > > > >
> > > > > > > > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> > > > > > > > ---
> > > > > > > >      include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
> > > > > > > >      1 file changed, 2 insertions(+), 1 deletion(-)
> > > > > > > >
> > > > > > > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > > > > > > index 5790b1391201..50ba72980190 100644
> > > > > > > > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > > > > > > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > > > > > > @@ -733,8 +733,9 @@
> > > > > > > >      #define ACLK_AV1_PRE			718
> > > > > > > >      #define PCLK_AV1_PRE			719
> > > > > > > >      #define HCLK_SDIO_PRE			720
> > > > > > > > +#define PCLK_VO1GRF			721
> > > > > > > > -#define CLK_NR_CLKS			(HCLK_SDIO_PRE + 1)
> > > > > > > > +#define CLK_NR_CLKS			(PCLK_VO1GRF + 1)
> > > > > > > This definition is part of the ABI, if it is safe to change it, then it
> > > > > > > is safe to delete it.
> > > > > > The new ID is to solve the niu clock dependency problem(Used in PATCH V5
> > > > > > 4/4).This new ID will also be used in DTS in the future.
> > > > > >
> > > > > > CLK_NR_CLKS represents the number of clocks used by the
> > > > > > drivers/clk/rockchip/clk-rkxxx.c. It is safe to modify it, but cannot delete
> > > > > > it.
> > > > > Then delete it from the header and move it to clk-rkxxx.c
> > > > I don't think it's more appropriate to move to clk-rkxxx.c.
> > > > Because if there are new requirements later, and add new clk id, it is
> > > > not in the same file, maybe forget to modify CLK_NR_CLKS.
> > > Then you are not allowed to change it. It's part of ABI.
> > If you just don't want me to modify CLK_NR_CLKS, can I use an unused ID,
> > like [PATCH V4 3/4]:
> >
> > -#define MBIST_MCLK_PDM1                        24
> > +#define PCLK_VO1GRF                    24
> You cannot change the ABI.
>
> I don't understand why do you insist on this path. You got clear
> comments: either this is ABI, so it cannot be changed, or it has to be
> dropped. You know insist on some third path. There is no such.
Ok , I'll drop this change in PATCH V6.
> Best regards,
> Krzysztof
--
张晴
瑞芯微电子股份有限公司
Rockchip Electronics Co.,Ltd
地址：福建省福州市铜盘路软件大道89号软件园A区21号楼
Add:No.21 Building, A District, No.89 Software Boulevard Fuzhou, Fujian 350003, P.R.China
Tel:+86-0591-83991906-8601
邮编：350003
E-mail:elaine.zhang@xxxxxxxxxxxxxx
****************************************************************************
保密提示：本邮件及其附件含有机密信息，仅发送给本邮件所指特定收件人。若非该特定收件人，请勿复制、使用或披露本邮件的任何内容。若误收本邮件，请从系统中永久性删除本邮件及所有附件，并以回复邮件或其他方式即刻告知发件人。福州瑞芯微电子有限公司拥有本邮件信息的著作权及解释权，禁止任何未经授权许可的侵权行为。

IMPORTANT NOTICE: This email is from Fuzhou Rockchip Electronics Co., Ltd .The contents of this email and any attachments may contain information that is privileged, confidential and/or exempt from disclosure under applicable law and relevant NDA. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, or use of the information is STRICTLY PROHIBITED. Please immediately contact the sender as soon as possible and destroy the material in its entirety in any format. Thank you.

****************************************************************************