Re: [PATCH] Revert "i2c: pxa: move to generic GPIO recovery"

[Andi Shyti]

Hi Marko,

On Fri, Nov 10, 2023 at 09:44:08AM +0000, Russell King (Oracle) wrote:
> On Fri, Nov 10, 2023 at 10:30:11AM +0100, Robert Marko wrote:
> > This reverts commit 0b01392c18b9993a584f36ace1d61118772ad0ca.
> > 
> > Conversion of PXA to generic I2C recovery, makes the I2C bus completely
> > lock up if recovery pinctrl is present in the DT and I2C recovery is
> > enabled.
> > 
> > So, until the generic I2C recovery can also work with PXA lets revert
> > to have working I2C and I2C recovery again.

Reverts are never nice, but if you are confirming this doesn't
work I can't do anything else than acking and bringing the driver
back to a working status.

Acked-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

I would have preferred a different fix, directly in the generic
i2c recovery, but this goes beyond the scope of the patch.

> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # 5.11+
> 
> My feels were that this should not have been converted to the generic
> recovery as pointed out at the time, so thanks for confirming that it
> broke as a result of that conversion, it did indeed break.
> 
> Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks Russel!

Andi