Re: [PATCH v13 05/10] usb: dwc3: qcom: Refactor IRQ handling in QCOM Glue driver

[Krishna Kurapati PSSNV]

> > While I do so, since there are no qusb2 targets present on femto phy's, do
> > you suggest we still add them to port structure in dwc3-qcom ? I am inclined
> > to add it because it would make implementation look cleaner w.r.t code and
> > also spurious interrupts are not getting triggered (which was my primary
> > concern as it was never tested).
>
> Yes, that's what I've been suggesting all along. It's a per-port
> interrupt so that's where it belongs.
>
> We should still try to determine when each interrupt should be enabled
> and how best to implement that (hence all my questions).
>
> For example, if there is no use for hs interrupts on SoCs using femto
> PHYs we should fix the bindings. If we can use dp/dm on SoCs using QUSB2
> PHYs, we should probably just ignore the hs interrupt when all three are
> defined (especially since that functionality has never worked anyway).

Sure. Will finalise this once I get the complete info (why do we have 
dp/dm on qusb targets)

And apologies, I mentioned "qusb2 targets on femto phy's".
It was supposed to be "hs_phy_irq's on femto phy targets", but I think 
you got the gist of my question. Thanks for the response.

Regards,
Krishna,