Re: [PATCH] mwifiex: clean up some inconsistent indenting

[Johannes Berg]

On Fri, 2023-11-10 at 16:38 -0800, Jeff Johnson wrote:
> > drivers/net/wireless/marvell/mwifiex/sta_event.c:789 mwifiex_process_sta_event() warn: inconsistent indenting.
> > 
> > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>

> >  		if (!adapter->pps_uapsd_mode &&
> >  		    (priv->port_open ||
> > -		     (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
> > +		    (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
> 
> this change looks incorrect to me
> this condition is *inside* the parenthesis from the beginning of the
> previous line, and hence this should align after that parenthesis, not
> with that parenthesis, which is what the existing code is doing

Hah, you're right, I completely missed that! I guess someone should fix
their tools :)

johannes