Re: [PATCH V2 2/6] pinctrl: sprd: Fix the incorrect mask and shift definition

[Linus Walleij]

On Fri, Sep 8, 2023 at 7:52 AM Linhua Xu <Linhua.xu@xxxxxxxxxx> wrote:

> From: Linhua Xu <Linhua.Xu@xxxxxxxxxx>
>
> Pull-up and pull-down are mutually exclusive. When setting one of them,
> the bit of the other needs to be clear. Now, there are cases where pull-up
> and pull-down are set at the same time in the code, thus fix them.
>
> Signed-off-by: Linhua Xu <Linhua.Xu@xxxxxxxxxx>

I'm uncertain what to do with this patch because it fixes something
while there are unaddressed review comments, I think we need
some more discussion here?

Yours,
Linus Walleij