Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

[Andy Shevchenko]

On Mon, Nov 13, 2023 at 03:15:58PM +0100, Linus Walleij wrote:
> Hi Larry, Andy,
> 
> On Tue, Oct 31, 2023 at 2:51 AM larry.lai <larry.lai@xxxxxxxxxxxxxxx> wrote:
> 
> > The UP Squared board <http://www.upboard.com> implements certain
> > features (pin control) through an on-board FPGA.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>

It may not be reported as it's brand new code.

> > Signed-off-by: Gary Wang <garywang@xxxxxxxxxxxx>
> > Signed-off-by: larry.lai <larry.lai@xxxxxxxxxxxxxxx>

(...)

> > +#include "core.h"
> > +#include "intel/pinctrl-intel.h"

> As mentioned this is using the intel core pin control driver infrastructure
> so I want Andy's ACK on this before I merge it.

I'm pretty much sure it's an abuse of that.

I guess I told this already in the previous rounds of review... I'll try to
find time to look at this, but it looks like it still needs some job before
being taken.

-- 
With Best Regards,
Andy Shevchenko