Re: [PATCH v2 1/1] driver core: Keep the supplier fwnode consistent with the device

From: Herve Codina
Date: Tue Nov 14 2023 - 02:20:45 EST


Hi Saravana,

On Mon, 13 Nov 2023 12:09:43 -0800
Saravana Kannan <saravanak@xxxxxxxxxx> wrote:

> On Mon, Nov 13, 2023 at 5:30 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:
> >
> > The commit 3a2dbc510c43 ("driver core: fw_devlink: Don't purge child
> > fwnode's consumer links") introduces the possibility to use the
> > supplier's parent device instead of the supplier itself.
> > In that case the supplier fwnode used is not updated and is no more
> > consistent with the supplier device used.
>
> Looks like you missed this comment from my previous reply.
>
> Nack. It's easier to debug when you know what supplier you were
> pointing to in DT that triggered the creation of the device link.
>
> It can get confusing real quick otherwise.

Sorry,
In the next iteration, I will keep the original supplier handle for
debug prints.

Regards,
Hervé