Re: [PATCH v4 3/4] platform/x86: hp-bioscfg: Fix error handling in hp_add_other_attributes()

[Ilpo Järvinen]

On Tue, 14 Nov 2023, Hans de Goede wrote:
> On 11/14/23 11:31, Ilpo Järvinen wrote:
> > On Mon, 13 Nov 2023, Harshit Mogalapalli wrote:
> > 
> >> 'attr_name_kobj' is allocated using kzalloc, but on all the error paths
> >> it is not freed, hence we have a memory leak.
> >>
> >> Fix the error path before kobject_init_and_add() by adding kfree().
> >>
> >> kobject_put() must be always called after passing the object to
> >> kobject_init_and_add(). Only the error path which is immediately next
> >> to kobject_init_and_add() calls kobject_put() and not any other error
> >> path after it.
> >>
> >> Fix the error handling after kobject_init_and_add() by moving the
> >> kobject_put() into the goto label err_other_attr_init that is already
> >> used by all the error paths after kobject_init_and_add().
> >>
> >> Fixes: a34fc329b189 ("platform/x86: hp-bioscfg: bioscfg")
> >> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >> Reported-by: Dan Carpenter <error27@xxxxxxxxx>
> >> Closes: https://lore.kernel.org/r/202309201412.on0VXJGo-lkp@xxxxxxxxx/
> >> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> >> ---
> >> This is based on static analysis, only compile tested.
> >>
> >> v3->v4: Add more explicit statement on how we are fixing it, suggested
> >> by Ilpo
> > 
> > Thanks a lot, this looks fine too now.
> > 
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> 
> Thank you for reviewing this series. I believe that it is best
> to submit this as fixes for the current cycle.
> 
> Under the assumption that you agree with this I've delegated
> these 4 patches to you (Ilpo) in patchwork.

Yes, I'll take care of it later this week.

-- 
 i.