Re: [PATCH 1/3] iio: adc: ad7192: Use device api

[Alisa-Dariana Roman]

On 06.11.2023 11:24, Krzysztof Kozlowski wrote:
> On 05/11/2023 20:31, alisadariana@xxxxxxxxx wrote:
> > From: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
> >
> > Replace of.h and corresponding functions with preferred device specific
> > functions.
> >
> > Also replace of_device_get_match_data function with
> > spi_get_device_match_data.
> >
> > Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
> > ---
> >   drivers/iio/adc/ad7192.c | 32 +++++++++++++++-----------------
> >   1 file changed, 15 insertions(+), 17 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7192.c b/drivers/iio/adc/ad7192.c
> > index adc3cbe92d6e..48e0357564af 100644
> > --- a/drivers/iio/adc/ad7192.c
> > +++ b/drivers/iio/adc/ad7192.c
> > @@ -17,7 +17,6 @@
> >   #include <linux/err.h>
> >   #include <linux/sched.h>
> >   #include <linux/delay.h>
> > -#include <linux/of.h>
> >   
> >   #include <linux/iio/iio.h>
> >   #include <linux/iio/sysfs.h>
> > @@ -364,19 +363,19 @@ static inline bool ad7192_valid_external_frequency(u32 freq)
> >   		freq <= AD7192_EXT_FREQ_MHZ_MAX);
> >   }
> >   
> > -static int ad7192_of_clock_select(struct ad7192_state *st)
> > +static int ad7192_device_clock_select(struct ad7192_state *st)
> >   {
> > -	struct device_node *np = st->sd.spi->dev.of_node;
> > +	struct device *dev = &st->sd.spi->dev;
> >   	unsigned int clock_sel;
> >   
> >   	clock_sel = AD7192_CLK_INT;
> >   
> >   	/* use internal clock */
> >   	if (!st->mclk) {
> > -		if (of_property_read_bool(np, "adi,int-clock-output-enable"))
> > +		if (device_property_read_bool(dev, "adi,int-clock-output-enable"))
> >   			clock_sel = AD7192_CLK_INT_CO;
> >   	} else {
> > -		if (of_property_read_bool(np, "adi,clock-xtal"))
> > +		if (device_property_read_bool(dev, "adi,clock-xtal"))
> >   			clock_sel = AD7192_CLK_EXT_MCLK1_2;
> >   		else
> >   			clock_sel = AD7192_CLK_EXT_MCLK2;
> > @@ -385,9 +384,10 @@ static int ad7192_of_clock_select(struct ad7192_state *st)
> >   	return clock_sel;
> >   }
> >   
> > -static int ad7192_setup(struct iio_dev *indio_dev, struct device_node *np)
> > +static int ad7192_setup(struct iio_dev *indio_dev)
> >   {
> >   	struct ad7192_state *st = iio_priv(indio_dev);
> > +	struct device *dev = &st->sd.spi->dev;
> >   	bool rej60_en, refin2_en;
> >   	bool buf_en, bipolar, burnout_curr_en;
> >   	unsigned long long scale_uv;
> > @@ -416,26 +416,26 @@ static int ad7192_setup(struct iio_dev *indio_dev, struct device_node *np)
> >   
> >   	st->conf = FIELD_PREP(AD7192_CONF_GAIN_MASK, 0);
> >   
> > -	rej60_en = of_property_read_bool(np, "adi,rejection-60-Hz-enable");
> > +	rej60_en = device_property_read_bool(dev, "adi,rejection-60-Hz-enable");
>
> Not strictly related to your patch, but where are these properties
> documented?
>
>
> Best regards,
> Krzysztof
Thank you for the feedback! The properties are documented in
Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml. But the
properties related to the clock configuration are indeed missing. I will
add them.

Kind regards,
Alisa-Dariana Roman