Re: [PATCH v2 1/2] perf: starfive: Add StarLink PMU support
From: kernel test robot
Date: Tue Nov 14 2023 - 21:07:36 EST
Hi Ji,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on arm-perf/for-next/perf tip/smp/core linus/master v6.7-rc1 next-20231114]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ji-Sheng-Teoh/perf-starfive-Add-StarLink-PMU-support/20231114-101811
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231114021254.3009799-2-jisheng.teoh%40starfivetech.com
patch subject: [PATCH v2 1/2] perf: starfive: Add StarLink PMU support
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20231114/202311142041.nSLDeqju-lkp@xxxxxxxxx/config)
compiler: riscv64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231114/202311142041.nSLDeqju-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <yujie.liu@xxxxxxxxx>
| Closes: https://lore.kernel.org/r/202311142041.nSLDeqju-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/perf/starfive_starlink_pmu.c:158:6: warning: no previous prototype for 'starlink_pmu_set_event_period' [-Wmissing-prototypes]
158 | void starlink_pmu_set_event_period(struct perf_event *event)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/starlink_pmu_set_event_period +158 drivers/perf/starfive_starlink_pmu.c
cff226048d4861 Ji Sheng Teoh 2023-11-14 157
cff226048d4861 Ji Sheng Teoh 2023-11-14 @158 void starlink_pmu_set_event_period(struct perf_event *event)
cff226048d4861 Ji Sheng Teoh 2023-11-14 159 {
cff226048d4861 Ji Sheng Teoh 2023-11-14 160 struct starlink_pmu *starlink_pmu = to_starlink_pmu(event->pmu);
cff226048d4861 Ji Sheng Teoh 2023-11-14 161 struct hw_perf_event *hwc = &event->hw;
cff226048d4861 Ji Sheng Teoh 2023-11-14 162 int idx = event->hw.idx;
cff226048d4861 Ji Sheng Teoh 2023-11-14 163
cff226048d4861 Ji Sheng Teoh 2023-11-14 164 /*
cff226048d4861 Ji Sheng Teoh 2023-11-14 165 * Program counter to half of it's max count to handle
cff226048d4861 Ji Sheng Teoh 2023-11-14 166 * cases of extreme interrupt latency.
cff226048d4861 Ji Sheng Teoh 2023-11-14 167 */
cff226048d4861 Ji Sheng Teoh 2023-11-14 168 u64 val = STARLINK_PMU_COUNTER_MASK >> 1;
cff226048d4861 Ji Sheng Teoh 2023-11-14 169
cff226048d4861 Ji Sheng Teoh 2023-11-14 170 local64_set(&hwc->prev_count, val);
cff226048d4861 Ji Sheng Teoh 2023-11-14 171 if (hwc->config == CYCLES)
cff226048d4861 Ji Sheng Teoh 2023-11-14 172 writeq(val, starlink_pmu->pmu_base + STARLINK_PMU_CYCLE_COUNTER);
cff226048d4861 Ji Sheng Teoh 2023-11-14 173 else
cff226048d4861 Ji Sheng Teoh 2023-11-14 174 writeq(val, starlink_pmu->pmu_base + STARLINK_PMU_EVENT_COUNTER +
cff226048d4861 Ji Sheng Teoh 2023-11-14 175 idx * sizeof(u64));
cff226048d4861 Ji Sheng Teoh 2023-11-14 176 }
cff226048d4861 Ji Sheng Teoh 2023-11-14 177
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki