Re: [PATCH for-next 3/3] RDMA/hns: Support SW stats with debugfs

[Leon Romanovsky]

On Tue, Nov 14, 2023 at 08:34:49PM +0800, Junxian Huang wrote:
> Support SW stats with debugfs.
> 
> Query output:
> $ cat /sys/kernel/debug/hns_roce/hns_0/sw_stat/sw_stat
> aeqe                 --- 3341
> ceqe                 --- 0
> cmds                 --- 6764
> cmds_err             --- 0
> posted_mbx           --- 3344
> polled_mbx           --- 3
> mbx_event            --- 3341
> qp_create_err        --- 0
> qp_modify_err        --- 0
> cq_create_err        --- 0
> cq_modify_err        --- 0
> srq_create_err       --- 0
> srq_modify_err       --- 0
> xrcd_alloc_err       --- 0
> mr_reg_err           --- 0
> mr_rereg_err         --- 0
> ah_create_err        --- 0
> mmap_err             --- 0
> uctx_alloc_err       --- 0

>From one side, 
Everything will be much easier if you use one file == one value. It will
remove the need in seq_* calls. Your "cat ../sw_stat" is not atomic and
doesn't present snapshot anyway.

>From another,
It is debugfs and it is upto you.

Let's wait a couple of days more and if no one complains, I'll apply it as is.

Thanks