Re: [RFC PATCH v2 0/7] of: Introduce hardware prober driver

From: Doug Anderson
Date: Wed Nov 15 2023 - 15:45:15 EST


Hi,

On Wed, Nov 15, 2023 at 2:28 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote:
>
> > So if we're searching the whole device tree for "failed-needs-probe"
> > then we need to figure out which devices are related to each other. If
> > a given board has second sources for MIPI panels, touchscreens, and
> > trackpads then we need to know which of the "failed-needs-probe"
> > devices are trackpads, which are touchscreens, and which are MIPI
> > panels. Do you have any suggestions for how we should do that? Maybe
> > it was in some other thread that I missed? I guess we could have a
> > board-specific table mapping (compatible + node name + reg) to a
> > class, but that feels awkward.
>
> Node name is supposed to correspond to device class, so why not use
> that (no path or unit-address.) and nothing else (well, besides
> "status")?

One problem is that I could imagine having two second source trackpads
that both have the same i2c address. That would give them the same
name, right? I guess you could maybe come up with some sort of suffix
rule? Like

trackpad-1@10 {
compatible = "elan,blah";
ret = <0x10>;
status = "failed-needs-probe";
...
}
trackpad-2@10 {
compatible = "goodix,gt7375p";
ret = <0x10>;
status = "failed-needs-probe";
...
}

Then I guess the class would be "trackpad"?


-Doug