Re: [PATCH] rxrpc_find_service_conn_rcu: use read_seqbegin() rather than read_seqbegin_or_lock()

From: Oleg Nesterov
Date: Thu Nov 16 2023 - 10:08:06 EST


On 11/16, David Howells wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> > > > - the usage of read_seqbegin_or_lock/need_seqretry in
> > > > this code makes no sense because read_seqlock_excl()
> > > > is not possible
> > >
> > > Not exactly. I think it should take a lock on the second pass.
> >
> > OK, then how about the patch below?
>
> That seems to work.

OK, I'll send V2 tomorrow.

Should I change fs/afs the same way?

Oleg.