Re: [PATCH] iio: honeywell,mprls0025pa.yaml: fix function numbering

[Conor Dooley]

On Thu, Nov 16, 2023 at 07:24:43PM +0100, Andreas Klinger wrote:
> Fix wrongly documented numbering of transfer functions.
> 
> Fixes: a765c985e696 ("dt-bindings: iio: pressure: Support Honeywell mprls0025pa sensor")
>

No blank line here.

> Suggested-by: Petre Rodan <petre.rodan@xxxxxxxxxxxxxxx>

This should be Reported-by.

> Signed-off-by: Andreas Klinger <ak@xxxxxxxxxxxxx>
> ---
>  .../bindings/iio/pressure/honeywell,mprls0025pa.yaml        | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> index b31f8120f14e..61775eff1128 100644
> --- a/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,mprls0025pa.yaml
> @@ -64,9 +64,9 @@ properties:
>      description: |
>        Transfer function which defines the range of valid values delivered by the
>        sensor.
> -      1 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> -      2 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> -      3 - C, 20% to 80% of 2^24 (3355443 .. 13421773)
> +      0 - A, 10% to 90% of 2^24 (1677722 .. 15099494)
> +      1 - B, 2.5% to 22.5% of 2^24 (419430 .. 3774874)
> +      2 - C, 20% to 80% of 2^24 (3355443 .. 13421773)

I don't understand. These are arbitrary numbers in a dt-binding, why
does zero or one indexing make any difference here?
Can't you just fix up the driver to correctly map the dt-binding to
whatever needs to be written to registers in the hardware?

Cheers,
Conor.

>      $ref: /schemas/types.yaml#/definitions/uint32
>  
>    vdd-supply:
> -- 
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature