Re: [PATCH 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support

[Alex Deucher]

On Mon, Nov 13, 2023 at 6:24 AM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>

Technically two separate drivers, if you feel like splitting it.  Either way,
Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>
Feel free to take this via the i2c tree if you prefer.

Alex

>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c |    1 -
>  drivers/gpu/drm/radeon/radeon_i2c.c     |    1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
> index 82608df43..d79cb13e1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c
> @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_device *dev,
>
>         i2c->rec = *rec;
>         i2c->adapter.owner = THIS_MODULE;
> -       i2c->adapter.class = I2C_CLASS_DDC;
>         i2c->adapter.dev.parent = dev->dev;
>         i2c->dev = dev;
>         i2c_set_adapdata(&i2c->adapter, i2c);
> diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
> index 314d066e6..3d174390a 100644
> --- a/drivers/gpu/drm/radeon/radeon_i2c.c
> +++ b/drivers/gpu/drm/radeon/radeon_i2c.c
> @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_device *dev,
>
>         i2c->rec = *rec;
>         i2c->adapter.owner = THIS_MODULE;
> -       i2c->adapter.class = I2C_CLASS_DDC;
>         i2c->adapter.dev.parent = dev->dev;
>         i2c->dev = dev;
>         i2c_set_adapdata(&i2c->adapter, i2c);
>