RE: [PATCH 2/6] irqchip: Add interrupt controller support for Realtek DHC SoCs
From: James Tai [戴志峰]
Date: Fri Nov 17 2023 - 04:49:14 EST
>>So you update the effective affinity even if it cannot be set or if the
>>parent irq returns an error code?
>>
>>Aside of that setting it to cpu_online mask is just wrong. This is
>>_NOT_ the effective affinity because the underlying GIC selects a
>>single target CPU out of the caller provides cpu mask.
>>
>>That said, this is also completely inconsistent vs. the other
>>interrupts which share that GIC interrupt instance. I.e.
>>/proc/irq/$N/affinity and effective_affinity become random number generators.
>That'll confuse existing userspace tools.
>>
>>Having an affinity setter for demultiplexes interrupts is simply wrong.
>>
>I will use the 'irq_chip_set_affinity_parent' replace the
>'realtek_intc_set_affinity'.
I will remove the capability to set CPU affinity.
Regards,
James