Re: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons

[Krzysztof Kozlowski]

On 17/11/2023 11:18, Tengfei Fan wrote:
> The Volume Down & Power buttons are controlled by the PMIC via the PON
> hardware, and the Volume Up is connected to a PMIC gpio.
> 
> Enable the necessary hardware and setup the GPIO state for the Volume Up
> gpio key.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@xxxxxxxxxxx>
> ---

No, really, necessary hardware? So why it is missing in the previous patch?

Stop useless splitting of work which is done. You cannot have "release
late, release often". The rule is: "release early, release often".

NAK.

Best regards,
Krzysztof