RE: [PATCH v3 1/4] phy: core: add notify_connect and notify_disconnect callback

[Stanley Chang[昌育德]]

Hi Vinod,

Please help review this patch.

Thanks,
Stanley

> -----Original Message-----
> From: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> Sent: Friday, November 10, 2023 1:45 PM
> To: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Stanley Chang[昌育德] <stanley_chang@xxxxxxxxxxx>; Vinod Koul
> <vkoul@xxxxxxxxxx>; Johan Hovold <johan@xxxxxxxxxx>; Kishon Vijay Abraham
> I <kishon@xxxxxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Jinjie
> Ruan <ruanjinjie@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Alan Stern
> <stern@xxxxxxxxxxxxxxxxxxx>; Yang Yingliang <yangyingliang@xxxxxxxxxx>;
> Flavio Suligoi <f.suligoi@xxxxxxx>; Roy Luo <royluo@xxxxxxxxxx>; Heikki
> Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>; Ricardo Cañuelo
> <ricardo.canuelo@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> linux-phy@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx
> Subject: [PATCH v3 1/4] phy: core: add notify_connect and notify_disconnect
> callback
> 
> In Realtek SoC, the parameter of usb phy is designed to can dynamic tuning
> base on port status. Therefore, add a notify callback of phy driver when usb
> connection/disconnection change.
> 
> Signed-off-by: Stanley Chang <stanley_chang@xxxxxxxxxxx>
> ---
> v1 to v2:
>     No change
> v2 to v3:
>     No change
> ---
>  drivers/phy/phy-core.c  | 47
> +++++++++++++++++++++++++++++++++++++++++
>  include/linux/phy/phy.h | 18 ++++++++++++++++
>  2 files changed, 65 insertions(+)
> 
> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index
> 96a0b1e111f3..a84ad4896b7f 100644
> --- a/drivers/phy/phy-core.c
> +++ b/drivers/phy/phy-core.c
> @@ -489,6 +489,53 @@ int phy_calibrate(struct phy *phy)  }
> EXPORT_SYMBOL_GPL(phy_calibrate);
> 
> +/**
> + * phy_notify_connect() - phy connect notify
> + * @phy: the phy returned by phy_get()
> + * @port: the port index for connect
> + *
> + * If phy need the get connection status, the callback can be used.
> + * Returns: %0 if successful, a negative error code otherwise  */ int
> +phy_notify_connect(struct phy *phy, int port) {
> +	int ret;
> +
> +	if (!phy || !phy->ops->connect)
> +		return 0;
> +
> +	mutex_lock(&phy->mutex);
> +	ret = phy->ops->connect(phy, port);
> +	mutex_unlock(&phy->mutex);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_notify_connect);
> +
> +/**
> + * phy_notify_disconnect() - phy disconnect notify
> + * @phy: the phy returned by phy_get()
> + * @port: the port index for disconnect
> + *
> + * If phy need the get disconnection status, the callback can be used.
> + *
> + * Returns: %0 if successful, a negative error code otherwise  */ int
> +phy_notify_disconnect(struct phy *phy, int port) {
> +	int ret;
> +
> +	if (!phy || !phy->ops->disconnect)
> +		return 0;
> +
> +	mutex_lock(&phy->mutex);
> +	ret = phy->ops->disconnect(phy, port);
> +	mutex_unlock(&phy->mutex);
> +
> +	return ret;
> +}
> +EXPORT_SYMBOL_GPL(phy_notify_disconnect);
> +
>  /**
>   * phy_configure() - Changes the phy parameters
>   * @phy: the phy returned by phy_get()
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index
> f6d607ef0e80..cf98cb29ddaa 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -122,6 +122,8 @@ struct phy_ops {
>  			    union phy_configure_opts *opts);
>  	int	(*reset)(struct phy *phy);
>  	int	(*calibrate)(struct phy *phy);
> +	int	(*connect)(struct phy *phy, int port);
> +	int	(*disconnect)(struct phy *phy, int port);
>  	void	(*release)(struct phy *phy);
>  	struct module *owner;
>  };
> @@ -243,6 +245,8 @@ static inline enum phy_mode phy_get_mode(struct
> phy *phy)  }  int phy_reset(struct phy *phy);  int phy_calibrate(struct phy
> *phy);
> +int phy_notify_connect(struct phy *phy, int port); int
> +phy_notify_disconnect(struct phy *phy, int port);
>  static inline int phy_get_bus_width(struct phy *phy)  {
>  	return phy->attrs.bus_width;
> @@ -396,6 +400,20 @@ static inline int phy_calibrate(struct phy *phy)
>  	return -ENOSYS;
>  }
> 
> +static inline int phy_notify_connect(struct phy *phy, int index) {
> +	if (!phy)
> +		return 0;
> +	return -ENOSYS;
> +}
> +
> +static inline int phy_notify_disconnect(struct phy *phy, int index) {
> +	if (!phy)
> +		return 0;
> +	return -ENOSYS;
> +}
> +
>  static inline int phy_configure(struct phy *phy,
>  				union phy_configure_opts *opts)
>  {
> --
> 2.34.1