Re: [PATCH 1/2] dt-bindings: power: rpmpd: Update part number to X1E80100

[Sibi Sankar]

On 11/18/23 05:10, Konrad Dybcio wrote:
> On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
> > On 17/11/2023 12:46, Sibi Sankar wrote:
> > > Hey Krzysztof,
> > >
> > > Thanks for taking time to review the series.
> > >
> > > On 11/17/23 16:35, Krzysztof Kozlowski wrote:
> > > > On 17/11/2023 11:42, Sibi Sankar wrote:
> > > > > Replace SC8380xp with the updated part number (X1E80100).
> > > >
> > > > You need to explain why. We don't update compatibles based on marketing
> > > > wishes.
> > >
> > > What we imply is that X1E80100 is the part number you would get when you
> > > read out from a Snapdragon X Elite device in the wild, when it is
> > > available and we didn't have this information when we posted out v1.
> >
> > The commit msg must explain why.
> (what Krzysztof meant is that your explanation is ok but it needs to be
> part of the commit message and not just a reply here)
>
> Moreover, it would also be good to say something like "this binding has
> no users and has been erroneusly introduced very recently, so it was
> decided that changing it is okay", as this is a rather special case.

Thanks, was going to do the same.

-Sibi

> Konrad