RE: [PATCH V6][4/4] dt-bindings: mmc: Add dt-bindings for realtek mmc driver

[Jyan Chou [周芷安]]

>> Document the device-tree bindings for Realtek SoCs mmc driver.

> Subject and commit msg - drop driver and describe hardware instead.
> s/mmc/MMC/

>>
>> Signed-off-by: Jyan Chou <jyanchou@xxxxxxxxxxx>
>>
>> ---
>> v5 -> v6:
>> - Drop the incorrect, generic compatible and modify it to specific.
>> - Drop useless properties.

> Which ones?

I will describe it clearly in our new version, the useless properties we dropped were

like some were not be used in our driver and some you asked us to dropped.

>> - Modify bindings to make DTS and driver match.
>>
>> v4 -> v5:
>> - Remove unused property, e.g.,cqe, resets, clock-freq-min-max.
>> - Fix indentation.
>>
>> v3 -> v4:
>> - Describe the items to make properties and item easy to understand.
>> - Fix examples' indentation and compiling error.
>> - Drop useless properties.
>>
>> v2 -> v3:
>> - Modify dt-bindings' content and description.
>> - Fix coding style.
>> - Update the list of maintainers.
>>
>> v1 -> v2:
>> - Add dt-bindings.
>> ---
>>  .../bindings/mmc/realtek,rtd-dw-cqe-emmc.yaml | 162 
>> ++++++++++++++++++
>>  1 file changed, 162 insertions(+)
>>  create mode 100644 
>> Documentation/devicetree/bindings/mmc/realtek,rtd-dw-cqe-emmc.yaml
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/mmc/realtek,rtd-dw-cqe-emmc.yaml 
>> b/Documentation/devicetree/bindings/mmc/realtek,rtd-dw-cqe-emmc.yaml
>> new file mode 100644
>> index 000000000000..d7118cf457e8
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mmc/realtek,rtd-dw-cqe-emmc.ya
>> +++ ml
>> @@ -0,0 +1,162 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/mmc/realtek,rtd-dw-cqe-emmc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Realtek DesignWare mobile storage host controller
>> +
>> +description:
>> +  Realtek uses the Synopsys DesignWare mobile storage host controller
>> +  to interface a SoC with storage medium. This file documents the 
>> +Realtek
>> +  specific extensions.
>> +
>> +maintainers:
>> +  - Jyan Chou <jyanchou@xxxxxxxxxxx>
>> +
>> +allOf:
>> +  - $ref: synopsys-dw-mshc-common.yaml#
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - realtek,rtd1325-dw-cqe-emmc
>> +      - realtek,rtd1319-dw-cqe-emmc
>> +      - realtek,rtd1315e-dw-cqe-emmc
>> +      - realtek,rtd1619b-dw-cqe-emmc
>> +
>> +  reg:
>> +    items:
>> +      - description: emmc base address
>> +      - description: cqhci base address
>> +
>> +  reg-names:
>> +    items:
>> +      - const: emmc
>> +      - const: cqhci
>> +
>> +  realtek,m2tmx:
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +    description: Phandle to m2tmx syscon register region.

> There is no such stuff as "syscon register region". Syscon is Linux term. Please write here instead the full name of the hardware block and describe its purpose (for what is it needed for).

Okay, we will correct it in our new version, thanks.

>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 4
>> +
>> +  clock-names:
>> +    items:
>> +      - const: biu
>> +      - const: ciu
>> +      - const: vp0
>> +      - const: vp1
>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  reset-names:
>> +    const: reset

> Nothing improved here.

> Go back to previous versions and implement the feedback you received.

Sorry for asking, but I would like to check if I exactly know your meaning first and 

then push our new patch. According to previous versions, I found out that 

>> +
>> +  resets:
>> +    maxItems: 1
>> +
>> +  reset-names:
>> +    const: reset

> And here you describe the item? The only place when it is not needed?
> Drop entierly.

does it means we need to drop it? But we need this to determine whether to

setup a reset control or not, if we didn't add it in our bindings, check patch will

show error. Did I misunderstand your meaning? Thanks.

Best regards,
Jyan