Re: [PATCH v2 6/7] ASoC: cs43130: Allow driver to work without IRQ thread

From: Mark Brown
Date: Mon Nov 20 2023 - 08:59:42 EST


On Mon, Nov 20, 2023 at 01:51:33PM +0000, Maciej Strozek wrote:
> W dniu pon, 20.11.2023 o godzinie 12∶31 +0000, użytkownik Mark Brown
> > On Mon, Nov 20, 2023 at 10:41:53AM +0000, Maciej Strozek wrote:

> > > This is to support systems without physical IRQ connection. The
> > > device
> > > only requires the IRQ for a couple of internal delays, this polling
> > > mechanism is a fallback when no IRQ is specified.

> > Your changelog here doesn't describe the change - is then intention
> > here
> > to remove the IRQ thread (and presumably open code?) or to make
> > interrupts entirely optional?

> Apologies, I thought the word "fallback" would describe the intention
> of making an optional way for the driver to work in absence of IRQ
> rather than removing the IRQ thread. Will send an amended (and
> unnumbered) v3.

Your subject line says that the patch is changing things to work
"without an IRQ thread" - the thread specifically. This conflicts with
the additional text you've added in the body of the changelog which
talks about removing the need
for an interrupt entirely.

Attachment: signature.asc
Description: PGP signature