Re: [PATCH v3 2/3] dt-bindings: iio: chemical: add aosong,ags02ma

[Anshul Dalal]

On 11/21/23 15:33, Krzysztof Kozlowski wrote:
> On 21/11/2023 10:57, Anshul Dalal wrote:
>> Add bindings for Aosong AGS02MA TVOC sensor.
>>
>> The sensor communicates over i2c with the default address 0x1a.
>> TVOC values can be read in the units of ppb and ug/m^3 at register 0x00.
>>
>> Datasheet:
>>   https://asairsensors.com/wp-content/uploads/2021/09/AGS02MA.pdf
>> Product-Page:
>>   http://www.aosong.com/m/en/products-33.html
>>
> 
> 
>> +---
>> +$id: http://devicetree.org/schemas/iio/chemical/aosong,ags02ma.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Aosong AGS02MA VOC Sensor
>> [..]
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    i2c {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        light-sensor@1a {
> 
> 
> You called it chemical, so why this is here light-sensor?

I was working on a binding for a light sensor in parallel at that time,
I probably forgot to change this when copying the example from the light
sensor.

Would be replaced by "voc-sensor" in the next revision, apologies for
any inconvenience.

Thanks for the review.

Best Regards,
Anshul