Re: [PATCH 2/2] r8152: Add RTL8152_INACCESSIBLE checks to more loops
From: Doug Anderson
Date: Tue Nov 21 2023 - 12:56:09 EST
Hi,
On Tue, Nov 21, 2023 at 2:28 AM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On Fri, 2023-11-17 at 13:08 -0800, Douglas Anderson wrote:
> > Previous commits added checks for RTL8152_INACCESSIBLE in the loops in
> > the driver. There are still a few more that keep tripping the driver
> > up in error cases and make things take longer than they should. Add
> > those in.
> >
> > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> I think this deserves a 'Fixes' tag. Please add it.
Sure, I can add it. It didn't feel worth it to me since there's no
real functional issue--just that it takes a little longer for these
loops to exit out, but it shouldn't hurt. I guess that means breaking
this commit into several depending on when the offending loop was
added.
> Additionally please insert the target tree in the subj prefix when re-
> postin (in this case 'net')
Funny, I just followed the tags for other commits to this file and the
"net:" prefix isn't common. I guess this should be "net: usb: r8152".
I can add it when I post v2.