Re: [PATCH v1] USB: gadget: core: adjust uevent timing on gadget unbind

From: Roy Luo
Date: Wed Nov 22 2023 - 18:14:02 EST


The logic is there since day 1 of udc in Commit
2ccea03a8f7ec93641791f2760d7cdc6cab6205f (usb: gadget: introduce UDC
Class). Do you still want me to put on a fix tag?

(Sorry for the spam, forgot to switch to plain text mode..)

On Wed, Nov 22, 2023 at 2:07 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Nov 22, 2023 at 10:00:01PM +0000, Roy Luo wrote:
> > The KOBJ_CHANGE uevent is sent before gadget unbind is actually
> > executed, resulting in inaccurate uevent emitted at incorrect timing
> > (the uevent would have USB_UDC_DRIVER variable set while it would
> > soon be removed).
> > Move the KOBJ_CHANGE uevent to the end of the unbind function so that
> > uevent is sent only after the change has been made.
> >
> > Signed-off-by: Roy Luo <royluo@xxxxxxxxxx>
> > ---
> > drivers/usb/gadget/udc/core.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> What commit does this fix?
>
>