Re: [net-next PATCH v3 2/2] octeontx2-pf: TC flower offload support for mirror

From: Paolo Abeni
Date: Thu Nov 23 2023 - 05:21:47 EST


On Tue, 2023-11-21 at 15:48 +0100, Wojciech Drewek wrote:
>
> On 21.11.2023 10:43, Suman Ghosh wrote:
> > This patch extends TC flower offload support for mirroring
> > ingress/egress traffic to a different PF/VF. Below is an example
> > command,
> >
> > 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
> > skip_sw action mirred ingress mirror dev eth2'
> >
> > Signed-off-by: Suman Ghosh <sumang@xxxxxxxxxxx>
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@xxxxxxxxx>

Thank you for your review!

Please, additionally try to trim away the irrelevant part of the patch
when replying (in this case almost everything). That helps a lot
following the discussion, especially on long patches, thanks!

@Suman: please retain Wojciech's tag on next revision of this series.

Cheers,

Paolo