Re: [PATCH] gpiolib: sysfs: Fix improper error handling on failed export

[Andy Shevchenko]

On Thu, Nov 23, 2023 at 3:30 PM Boerge Struempfel
<boerge.struempfel@xxxxxxxxx> wrote:
>
> If gpio_set_transitory fails, we should free the gpio again. Most

We refer to functions as func() in the text and comments (note parentheses).

GPIO

> notably, the flag FLAG_REQUESTED has previously been set in
> gpiod_request_commit, and should be reset on failure.

Same about func().

...

Seems the correct fix, but you may also add that no existing user is
returning anything except 0 or ENOTSUPP that is converted to 0 in
GPIOLIB core code. Hence no Fixes tag is needed, but still possible if
maintainers want it.

-- 
With Best Regards,
Andy Shevchenko