Re: [PATCH v3 2/2] platform/x86: acer-wmi: add fan speed monitoring for Predator PHN16-71

From: Ilpo Järvinen
Date: Thu Nov 23 2023 - 10:32:09 EST


On Fri, 24 Nov 2023, SungHwan Jung wrote:

> Support CPU and GPU fan speed monitoring through WMI for Predator
> PHN16-71.
>
> This patch depends on patch "platform/x86: acer-wmi: Add platform
> profile and mode key support for Predator PHN16-71"
>
> "select ACPI_VIDEO" cause recursive dependency and it is not recommended
> to use "select" for visible symbol, "select" has changed to "depends on".

> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -177,7 +177,8 @@ config ACER_WMI
> depends on INPUT
> depends on RFKILL || RFKILL = n
> depends on ACPI_WMI
> - select ACPI_VIDEO
> + depends on HWMON
> + depends on ACPI_VIDEO

Also, please make own patch out of the ACPI_VIDEO change.

--
i.