Re: [PATCH 05/10] drivers/i2c/busses: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

[Peter Rosin]

Hi!

2023-11-18 at 19:04, Heiner Kallweit wrote:
> diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
> index e01d75308..9076ae4d7 100644
> --- a/drivers/i2c/busses/i2c-kempld.c
> +++ b/drivers/i2c/busses/i2c-kempld.c
> @@ -283,8 +283,8 @@ static const struct i2c_algorithm kempld_i2c_algorithm = {
>  static const struct i2c_adapter kempld_i2c_adapter = {
>  	.owner		= THIS_MODULE,
>  	.name		= "i2c-kempld",
> -	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD |
> -			  I2C_CLASS_DEPRECATED,
> +	.class		= I2C_CLASS_HWMON |
> +	I2C_CLASS_DEPRECATED,

The above is less than ideal...

It should obviously be:

-	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD |
-			  I2C_CLASS_DEPRECATED,
+	.class		= I2C_CLASS_HWMON | I2C_CLASS_DEPRECATED,

Cheers,
Peter