Re: d_genocide()? What about d_holodomor(), d_massmurder(), d_execute_warcrimes()? Re: [PATCH 15/20] d_genocide(): move the extern into fs/internal.h
From: Al Viro
Date: Fri Nov 24 2023 - 01:58:07 EST
On Fri, Nov 24, 2023 at 07:35:34AM +0100, Cedric Blancher wrote:
> On Fri, 24 Nov 2023 at 07:08, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> >
> > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > ---
> > fs/internal.h | 1 +
> > include/linux/dcache.h | 3 ---
> > 2 files changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/fs/internal.h b/fs/internal.h
> > index 9e9fc629f935..d9a920e2636e 100644
> > --- a/fs/internal.h
> > +++ b/fs/internal.h
> > @@ -219,6 +219,7 @@ extern void shrink_dcache_for_umount(struct super_block *);
> > extern struct dentry *__d_lookup(const struct dentry *, const struct qstr *);
> > extern struct dentry *__d_lookup_rcu(const struct dentry *parent,
> > const struct qstr *name, unsigned *seq);
> > +extern void d_genocide(struct dentry *);
>
> Seriously, who came up with THAT name? "Genocide" is not a nice term,
> not even if you ignore political correctness.
> Or what will be next? d_holodomor()? d_massmurder()? d_execute_warcrimes()?
kill_them_all(), on the account of that being what it's doing?
I can explain the problems with each of your suggested identifiers,
if you really wish that, but I would stronly suggest taking that off-list.
As for the bad words... google "jesux" someday. Yes, we do have
identifiers like "kill", "abort", etc. and those are really not going
anywhere; live with it.