[PATCH v4 3/3] platform/x86: acer-wmi: Fix recursive dependency for acer-wmi
From: SungHwan Jung
Date: Fri Nov 24 2023 - 04:42:49 EST
"select ACPI_VIDEO" cause recursive dependency when "depends on HWMON"
is added.
---build log
drivers/hwmon/Kconfig:6:error: recursive dependency detected!
drivers/hwmon/Kconfig:6: symbol HWMON is selected by EEEPC_LAPTOP
drivers/platform/x86/Kconfig:326: symbol EEEPC_LAPTOP depends on ACPI_VIDEO
drivers/acpi/Kconfig:208: symbol ACPI_VIDEO is selected by ACER_WMI
drivers/platform/x86/Kconfig:173: symbol ACER_WMI depends on HWMON
---
It is not recommended to use "select" for visible symbol, "select" has changed
to "depends on".
This patch depends on "platform/x86: acer-wmi: add fan speed monitoring
for Predator PHN16-71"
Signed-off-by: SungHwan Jung <onenowy@xxxxxxxxx>
---
drivers/platform/x86/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index caf3f4c6b..33ddb644e 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -178,7 +178,7 @@ config ACER_WMI
depends on RFKILL || RFKILL = n
depends on ACPI_WMI
depends on HWMON
- select ACPI_VIDEO
+ depends on ACPI_VIDEO
select INPUT_SPARSEKMAP
select LEDS_CLASS
select NEW_LEDS
--
2.43.0