Re: [PATCH] cpufreq/amd-pstate: Fix the return value of amd_pstate_fast_switch()

[Gautham R. Shenoy]

On Fri, Nov 24, 2023 at 03:31:34PM +0800, Huang Rui wrote:
> On Fri, Nov 24, 2023 at 12:23:58PM +0800, Karny, Wyes wrote:
> > On 23 Nov 13:57, Gautham R. Shenoy wrote:
> > > cpufreq_driver->fast_switch() callback expects a frequency as a return
> > > value. amd_pstate_fast_switch() was returning the return value of
> > > amd_pstate_update_freq(), which only indicates a success or failure.
> > > 
> > > Fix this by making amd_pstate_fast_switch() return the target_freq
> > > when the call to amd_pstate_update_freq() is successful, and return
> > > the current frequency from policy->cur when the call to
> > > amd_pstate_update_freq() is unsuccessful.
> > > 
> > > Fixes: 4badf2eb1e98 ("cpufreq: amd-pstate: Add ->fast_switch() callback")
> > 
> > Reviewed-by: Wyes Karny <wyes.karny@xxxxxxx>
> > 
> 
> Acked-by: Huang Rui <ray.huang@xxxxxxx>

Thanks!
> 
> Do you want to cc stable mailing list to fix it in stable kernels?

Yes, I forgot to do that. I will send a v2 having collected your
Acked-by and the Reviewed-by's from Perry and Wyes.

> 
> Thanks,
> Ray

--
Thanks and Regards
gautham.