Re: [PATCH net-next 0/7] net/smc: implement SMCv2.1 virtual ISM device support

[Wen Gu]

On 2023/11/24 21:34, Wen Gu wrote:
> On 2023/11/24 21:11, Wenjia Zhang wrote:
> > On 19.11.23 14:57, Wen Gu wrote:
> > > The fourth edition of SMCv2 adds the SMC version 2.1 feature updates for
> > > SMC-Dv2 with virtual ISM. Virtual ISM are created and supported mainly by
> > > OS or hypervisor software, comparable to IBM ISM which is based on platform
> > > firmware or hardware.
> > >
> > > With the introduction of virtual ISM, SMCv2.1 makes some updates:
> > >
> > > - Introduce feature bitmask to indicate supplemental features.
> > > - Reserve a range of CHIDs for virtual ISM.
> > > - Support extended GIDs (128 bits) in CLC handshake.
> > >
> > > So this patch set aims to implement these updates in Linux kernel. And it
> > > acts as the first part of the new version of [1].
> > >
> > > [1] https://lore.kernel.org/netdev/1695568613-125057-1-git-send-email-guwen@xxxxxxxxxxxxxxxxx/
> > >
> > > Wen Gu (7):
> > >    net/smc: Rename some variable 'fce' to 'fce_v2x' for clarity
> > >    net/smc: support SMCv2.x supplemental features negotiation
> > >    net/smc: introduce virtual ISM device support feature
> > >    net/smc: define a reserved CHID range for virtual ISM devices
> > >    net/smc: compatible with 128-bits extend GID of virtual ISM device
> > >    net/smc: disable SEID on non-s390 archs where virtual ISM may be used
> > >    net/smc: manage system EID in SMC stack instead of ISM driver
> > >
> > >   drivers/s390/net/ism.h     |  6 ---
> > >   drivers/s390/net/ism_drv.c | 54 +++++++--------------------
> > >   include/linux/ism.h        |  1 -
> > >   include/net/smc.h          | 16 +++++---
> > >   net/smc/af_smc.c           | 68 ++++++++++++++++++++++++++-------
> > >   net/smc/smc.h              |  7 ++++
> > >   net/smc/smc_clc.c          | 93 ++++++++++++++++++++++++++++++++--------------
> > >   net/smc/smc_clc.h          | 22 +++++++----
> > >   net/smc/smc_core.c         | 30 ++++++++++-----
> > >   net/smc/smc_core.h         |  8 ++--
> > >   net/smc/smc_diag.c         |  7 +++-
> > >   net/smc/smc_ism.c          | 57 ++++++++++++++++++++--------
> > >   net/smc/smc_ism.h          | 31 +++++++++++++++-
> > >   net/smc/smc_pnet.c         |  4 +-
> > >   14 files changed, 269 insertions(+), 135 deletions(-)
> >
> > Hi Wen Gu,
> >
> > Just FYI, the review is still on going and some tests on our plateform still need to do. I'll give you my comments as 
> > soon as the testing is done. I think it would be at the beginning of next week.
> >
> > Thanks,
> > Wenjia
>
> Hi Wenjian,
Wenjia.

Sorry for the typo.

> Thank you very much. I appreciate that you help to test them on your platform since I can only test
> them with loopback-ism.
>
> And I am going to send a new version which is rebased to the latest net-next and fix two existing
> comments. If the current tests have not started yet, could you please test based on my upcoming v2 ?
>
> Thanks and regards,
> Wen Gu