Re: [PATCH] kselftest/clone3: Make test names for set_tid test stable
From: Christian Brauner
Date: Fri Nov 24 2023 - 10:21:58 EST
On Wed, Nov 15, 2023 at 02:43:02PM +0000, Mark Brown wrote:
> The test results reported for the clone3_set_tid tests interact poorly with
> automation for running kselftest since the reported test names include TIDs
> dynamically allocated at runtime. A lot of automation for running kselftest
> will compare runs by looking at the test name to identify if the same test
> is being run so changing names make it look like the testsuite has been
> updated to include new tests. This makes the results display less clearly
> and breaks cases like bisection.
>
> Address this by providing a brief description of the tests and logging that
> along with the stable parameters for the test currently logged. The TIDs
> are already logged separately in existing logging except for the final test
> which has a new log message added. We also tweak the formatting of the
> logging of expected/actual values for clarity.
>
> There are still issues with the logging of skipped tests (many are simply
> not logged at all when skipped and all are logged with different names) but
> these are less disruptive since the skips are all based on not being run as
> root, a condition likely to be stable for a given test system.
>
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
May I already acked this. Not sure,
Acked-by: Christian Brauner <brauner@xxxxxxxxxx>