Re: [PATCH net-next v2] firmware_loader: Expand Firmware upload error codes with firmware invalid error

[Simon Horman]

On Wed, Nov 22, 2023 at 11:43:25AM +0100, Köry Maincent wrote:
> On Tue, 21 Nov 2023 17:30:22 -0800
> Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
> 
> > On Tue, 21 Nov 2023 11:50:35 +0100 Kory Maincent wrote:
> > > No error code are available to signal an invalid firmware content.
> > > Drivers that can check the firmware content validity can not return this
> > > specific failure to the user-space
> > > 
> > > Expand the firmware error code with an additional code:
> > > - "firmware invalid" code which can be used when the provided firmware
> > >   is invalid  
> > 
> > Any idea what this is?
> > 
> > lib/test_firmware.o: warning: objtool: test_fw_upload_prepare() falls through
> > to next function __cfi_test_fw_upload_cancel()
> > 
> > My build shows this on an incremental clang 17 build.
> 
> For my curiosity, how do you get this error?
> 
> Enabling test_firmware and building with W=1 does not show the error.

Hi Kory,

I am able to observe this warning when compiling with clang-16

make LLVM=1 lib/test_firmware.o

...