Re: [PATCH v3 02/13] scsi: fnic: Add and use fnic number

[Martin K. Petersen]

Hi Karan,

> Add fnic_num in fnic.h to identify fnic in a multi-fnic environment.
> Increment and set the fnic number during driver load in fnic_probe.
> Replace the host number with fnic number in debugfs.

I agree with Hannes. Everything else in the stack will be using the host
number. Your change will make it harder to correlate a SCSI error
message to an fnic driver instance.

If you absolutely need an instance number I suggest you add it as an
orthogonal value instead replacing the host. Also, we typically use an
idr for enumerating things like this.

-- 
Martin K. Petersen	Oracle Linux Engineering