Re: [PATCH v2 5/7] dt-bindings: iio: Add binding documentation for AD7091R-8

From: Conor Dooley
Date: Sat Nov 25 2023 - 07:21:35 EST


On Thu, Nov 23, 2023 at 01:42:21PM -0300, Marcelo Schmitt wrote:

> + spi-max-frequency: true

This is not needed, since you have unevaluatedProperties: false &
include the spi periph props.

> + adi,conversion-start-gpios:
> + description:

> + Device tree identifier of the CONVST pin.

"gpio connected to the CONVST pin".

> + This logic input is used to initiate conversions on the analog
> + input channels.
> + maxItems: 1

This looks pretty decent to be overall though.

Attachment: signature.asc
Description: PGP signature