Re: [PATCH v6 4/8] media: qcom: camss: Move VFE power-domain specifics into vfe.c

[Konrad Dybcio]

On 25.11.2023 13:53, Konrad Dybcio wrote:
> On 23.11.2023 18:03, Bryan O'Donoghue wrote:
>> Moving the location of the hooks to VFE power domains has several
>> advantages.
>>
>> 1. Separation of concerns and functional decomposition.
>>    vfe.c should be responsible for and know best how manage
>>    power-domains for a VFE, excising from camss.c follows this
>>    principle.
>>
>> 2. Embedding a pointer to genpd in struct camss_vfe{} meas that we can
>>    dispense with a bunch of kmalloc array inside of camss.c.
>>
>> 3. Splitting up titan top gdsc from vfe/ife gdsc provides a base for
>>    breaking up magic indexes in dtsi.
>>
>> Suggested-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>> Tested-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>> ---
> Reviewed-by: Konrad Dybcio <konrad.dybciolinaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad