Re: [PATCH 2/2] dt-bindings: iio: temperature: add MLX90635 device bindings

[Jonathan Cameron]

On Wed, 22 Nov 2023 13:35:19 +0100
Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> On 22/11/2023 13:28, Crt Mori wrote:
> >>> +  Since measured object emissivity effects Infra Red energy emitted,
> >>> +  emissivity should be set before requesting the object temperature.
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    const: melexis,mlx90635  
> >>
> >> It's the same as mlx90632. Add it there (as enum).
> >>  
> > 
> > Properties are the same, but then you can't have much differences for
> > a temperature sensor. It has a bit worse relative measurement error
> > outside of the human body range and overall different DSP, register
> > map, even physical size - it's 1.8x1.8 mm compared to 90632 3x3 mm. I
> > was not sure how it qualifies for adding it as another enum, but I
> > went with the feeling that if it can reuse the driver, then it is an
> > enum, otherwise it is a new file. And I could not reuse anything from
> > 90632.
> > 
> > Thanks for quick feedback and best regards,  
> 
> Driver is independent choice. There is no need for new binding file if
> everything is the same from bindings point of view.
> 
> Best regards,
> Krzysztof
> 
> 

We got this wrong in the past in IIO and it's a slow effort to merge
the various very similar bindings.  For now we are mostly keeping
to within a vendor though unless a driver supports parts from multiple
vendors.  It potentially gets too confusing to maintain otherwise.

This one is easy case though so definitely merge as Krzystof suggested!

Jonathan