Re: [PATCH 5/5] ext4: Add unit test for ext4_mb_mark_diskspace_used
From: kernel test robot
Date: Sat Nov 25 2023 - 12:35:23 EST
Hi Kemeng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tytso-ext4/dev]
[also build test WARNING on linus/master v6.7-rc2 next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kemeng-Shi/ext4-Add-unit-test-for-test_free_blocks_simple/20231125-154444
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
patch link: https://lore.kernel.org/r/20231125154144.3943442-6-shikemeng%40huaweicloud.com
patch subject: [PATCH 5/5] ext4: Add unit test for ext4_mb_mark_diskspace_used
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20231126/202311260042.kMxL6DnL-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231126/202311260042.kMxL6DnL-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311260042.kMxL6DnL-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
In file included from fs/ext4/mballoc.c:6996:
fs/ext4/mballoc-test.c:510:16: warning: variable 'max' set but not used [-Wunused-but-set-variable]
ext4_grpblk_t max;
^
>> fs/ext4/mballoc-test.c:506:13: warning: stack frame size (1036) exceeds limit (1024) in 'test_mark_diskspace_used' [-Wframe-larger-than]
static void test_mark_diskspace_used(struct kunit *test)
^
39/1036 (3.76%) spills, 997/1036 (96.24%) variables
2 warnings generated.
vim +/test_mark_diskspace_used +506 fs/ext4/mballoc-test.c
505
> 506 static void test_mark_diskspace_used(struct kunit *test)
507 {
508 struct super_block *sb = (struct super_block *)test->priv;
509 struct inode inode = { .i_sb = sb, };
510 ext4_grpblk_t max;
511 struct ext4_allocation_context ac;
512 struct test_range ranges[TEST_RANGE_COUNT];
513 int i;
514
515 mbt_generate_test_ranges(sb, ranges, TEST_RANGE_COUNT);
516
517 ac.ac_status = AC_STATUS_FOUND;
518 ac.ac_sb = sb;
519 ac.ac_inode = &inode;
520 max = EXT4_CLUSTERS_PER_GROUP(sb);
521 for (i = 0; i < TEST_RANGE_COUNT; i++)
522 test_mark_diskspace_used_range(test, &ac, ranges[i].start,
523 ranges[i].len);
524 }
525
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki