Re: [PATCH 2/6] twl-core: add power off implementation for twl603x
From: kernel test robot
Date: Sun Nov 26 2023 - 18:32:25 EST
Hi Andreas,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on lee-mfd/for-mfd-next linus/master v6.7-rc2 next-20231124]
[cannot apply to tmlind-omap/for-next lee-mfd/for-mfd-fixes]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andreas-Kemnade/dt-bindings-mfd-ti-twl-Document-system-power-controller/20231125-173426
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20231125092938.16535-3-andreas%40kemnade.info
patch subject: [PATCH 2/6] twl-core: add power off implementation for twl603x
config: x86_64-randconfig-122-20231126 (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@xxxxxxxxx/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311270558.j38P20an-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311270558.j38P20an-lkp@xxxxxxxxx/
sparse warnings: (new ones prefixed by >>)
>> drivers/mfd/twl-core.c:690:6: sparse: sparse: symbol 'twl6030_power_off' was not declared. Should it be static?
vim +/twl6030_power_off +690 drivers/mfd/twl-core.c
689
> 690 void twl6030_power_off(void)
691 {
692 #define APP_DEVOFF (1<<0)
693 #define CON_DEVOFF (1<<1)
694 #define MOD_DEVOFF (1<<2)
695
696 int err;
697 u8 val;
698
699 err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
700 TWL6030_PHOENIX_DEV_ON);
701 if (err) {
702 pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err);
703 return;
704 }
705
706 val |= APP_DEVOFF | CON_DEVOFF | MOD_DEVOFF;
707
708 err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
709 TWL6030_PHOENIX_DEV_ON);
710 if (err)
711 pr_err("TWL6030 Unable to power off\n");
712 }
713
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki