Re: [PATCH] leds: trigger: netdev: extend speeds up to 10G

[Lee Jones]

On Sun, 26 Nov 2023, Daniel Golle wrote:

> Hi Andrew,
> 
> On Sun, Nov 26, 2023 at 10:04:22PM +0100, Andrew Lunn wrote:
> > On Sun, Nov 26, 2023 at 08:17:03PM +0000, Daniel Golle wrote:
> > > Add 2.5G, 5G and 10G as available speeds to the netdev LED trigger.
> > > 
> > > Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>
> > 
> > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > 
> > One thing to consider is how this get merged. I assume you will have a
> > PHY driver patch soon making use of this?
> 
> Yes, exactly. I'm working on adding support for LEDs to MaxLinear and
> RealTek PHY drivers.
> 
> > We can either:
> > 
> > 1) Get Lee to merge it into the LED tree and then create a stable
> > branch which gets pulled into netdev.

I'll create an immutable branch.

> > 2) Merge into netdev, with Lees Acked-by: 
> > 
> > It seems unlikely there will be any merge conflicts. So netdev does
> > seem like an O.K. way to go.
> 
> Via netdev (net-next) would be better imho as it would allow to add
> changes to PHY drivers making use of the new constants without having
> to wait for LED tree being merged.

The former solution does not prevent this.

> Note that I've sent v2 which adds missing use of sysfs attributes.

-- 
Lee Jones [李琼斯]