Re: [RFC PATCH 3/3] drivers: misc: ti-st: begin to deorbit

From: Greg KH
Date: Mon Nov 27 2023 - 03:39:00 EST


On Sun, Nov 26, 2023 at 08:18:40PM +0100, Andreas Kemnade wrote:
> The TI-ST driver seems not to be used anymore. For bluetooth needs
> there is hci_ll.c which has device tree support and can work without
> this one. Also firmware download support is there, so it is also not needed
> here. GPS can also reuse parts of the framework in hci_ll
>
> Contrary from this driver, device tree support has been removed.
>
> So start deorbiting it by marking it as broken.
>
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
> drivers/misc/ti-st/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/ti-st/Kconfig b/drivers/misc/ti-st/Kconfig
> index 1503a6496f632..6bf9cc845745c 100644
> --- a/drivers/misc/ti-st/Kconfig
> +++ b/drivers/misc/ti-st/Kconfig
> @@ -7,7 +7,7 @@ menu "Texas Instruments shared transport line discipline"
> config TI_ST
> tristate "Shared transport core driver"
> depends on NET && TTY
> - depends on GPIOLIB || COMPILE_TEST
> + depends on GPIOLIB || COMPILE_TEST || BROKEN

Why not just delete it? Why have it stick around any longer?

thanks,

greg k-h