Re: [PATCH v2] iommu/tegra-smmu: drop error checking for debugfs_create_dir()

From: Joerg Roedel
Date: Mon Nov 27 2023 - 04:27:46 EST


On Wed, Oct 25, 2023 at 05:25:58PM +0200, Dario Binacchi wrote:
> The return value of debugfs_create_dir() should be checked using the
> IS_ERR() function. The patch, however, drops the check statement without
> fixing it because the subsequent functions (i. e. debugfs_create_file())
> can handle the case where `@parent` is an error pointer.

This deserves a comment in the code explaining why no error checking is
needed.

Regards,

Joerg