Re: [PATCH v8 3/5] media: stm32-dcmipp: STM32 DCMIPP camera interface driver

[Sakari Ailus]

Hi Alain,

On Wed, Nov 22, 2023 at 08:39:17AM +0100, Alain Volmat wrote:
> From: Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
> 
> This V4L2 subdev driver enables Digital Camera Memory Interface
> Pixel Processor(DCMIPP) of STMicroelectronics STM32 SoC series.
> 
> Signed-off-by: Hugues Fruchet <hugues.fruchet@xxxxxxxxxxx>
> Signed-off-by: Alain Volmat <alain.volmat@xxxxxxxxxxx>

One more thing. I think you're missing all the link_validate ops, meaning
it's possible to start the hardware with invalid configuration.

Could you add them? It can be a separate patch. I'll postpone these until
that.

-- 
Regards,

Sakari Ailus