Re: [PATCH v2] arm64: dts: freescale: debix-som-a-bmb-08: Add CSI Power Regulators

[Kieran Bingham]

Quoting Shawn Guo (2023-11-27 02:57:06)
> On Wed, Nov 01, 2023 at 10:46:11AM +0000, Kieran Bingham wrote:
> > Provide the 1.8 and 3.3 volt regulators that are utilised on the Debix
> > SOM BMB-08 base board.
> > 
> > Facilitate this by also supplying the pin control used to enable the
> > regulators on the second MIPI CSI port.
> > 
> > Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> > Signed-off-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>
> > 
> > ---
> > v2:
> >  - Remove _SW post fixes from regulators.
> > 
> >  .../freescale/imx8mp-debix-som-a-bmb-08.dts   | 56 +++++++++++++++++++
> >  1 file changed, 56 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > index 0b0c95432bdc..386177c66c6d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > @@ -63,6 +63,50 @@ regulator-som-vdd3v3 {
> >               regulator-always-on;
> >       };
> >  
> > +     reg_csi1_1v8: regulator-csi1-vdd1v8 {
> > +             compatible = "regulator-fixed";
> > +             regulator-min-microvolt = <1800000>;
> > +             regulator-max-microvolt = <1800000>;
> > +             regulator-name = "CSI1_VDD1V8";
> > +             gpio = <&expander0 13 GPIO_ACTIVE_HIGH>;
> > +             vin-supply = <&reg_baseboard_vdd3v3>;
> > +             enable-active-high;
> 
> Could you move it one line above, so that it appears right after
> GPIO_ACTIVE_HIGH polarity?

Yes, Sorry - I'm not sure why this is inconsistent with all the others.

v3 heading out next.

--
Kieran


> 
> Shawn
> 
> > +     };
> > +
> > +     reg_csi1_3v3: regulator-csi1-vdd3v3 {
> > +             compatible = "regulator-fixed";
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             regulator-name = "CSI1_VDD3V3";
> > +             gpio = <&expander0 14 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +             vin-supply = <&reg_vdd5v0>;
> > +     };
> > +
> > +     reg_csi2_1v8: regulator-csi2-vdd1v8 {
> > +             compatible = "regulator-fixed";
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_reg_csi2_1v8>;
> > +             regulator-min-microvolt = <1800000>;
> > +             regulator-max-microvolt = <1800000>;
> > +             regulator-name = "CSI2_VDD1V8";
> > +             gpio = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +             vin-supply = <&reg_baseboard_vdd3v3>;
> > +     };
> > +
> > +     reg_csi2_3v3: regulator-csi2-vdd3v3 {
> > +             compatible = "regulator-fixed";
> > +             pinctrl-names = "default";
> > +             pinctrl-0 = <&pinctrl_reg_csi2_3v3>;
> > +             regulator-min-microvolt = <3300000>;
> > +             regulator-max-microvolt = <3300000>;
> > +             regulator-name = "CSI2_VDD3V3";
> > +             gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
> > +             enable-active-high;
> > +             vin-supply = <&reg_vdd5v0>;
> > +     };
> > +
> >       regulator-vbus-usb20 {
> >               compatible = "regulator-fixed";
> >               regulator-min-microvolt = <5000000>;
> > @@ -413,6 +457,18 @@ MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03              0x41
> >               >;
> >       };
> >  
> > +     pinctrl_reg_csi2_1v8: regcsi21v8grp {
> > +             fsl,pins = <
> > +                     MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21              0x19
> > +             >;
> > +     };
> > +
> > +     pinctrl_reg_csi2_3v3: regcsi23v3grp {
> > +             fsl,pins = <
> > +                     MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25               0x19
> > +             >;
> > +     };
> > +
> >       pinctrl_uart2: uart2grp {
> >               fsl,pins = <
> >                       MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX            0x14f
> > -- 
> > 2.34.1
> >