Re: [PATCH 1/2] tick/nohz: Remove duplicate between tick_nohz_switch_to_nohz() and tick_setup_sched_timer()
From: kernel test robot
Date: Mon Nov 27 2023 - 10:22:34 EST
Hi Peng,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tip/timers/core]
[also build test WARNING on linus/master v6.7-rc3 next-20231127]
[cannot apply to tip/timers/nohz]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Peng-Liu/tick-nohz-Remove-duplicate-between-tick_nohz_lowres_handler-and-tick_nohz_highres_handler/20231127-163637
base: tip/timers/core
patch link: https://lore.kernel.org/r/TYCP286MB21464B3653B956AF71806931C6BDA%40TYCP286MB2146.JPNP286.PROD.OUTLOOK.COM
patch subject: [PATCH 1/2] tick/nohz: Remove duplicate between tick_nohz_switch_to_nohz() and tick_setup_sched_timer()
config: arc-defconfig (https://download.01.org/0day-ci/archive/20231127/202311272057.gNWmIyix-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231127/202311272057.gNWmIyix-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311272057.gNWmIyix-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
kernel/time/tick-sched.c:650: warning: Function parameter or member 'now' not described in 'tick_nohz_update_jiffies'
kernel/time/tick-sched.c:1282: warning: Function parameter or member 'cpu' not described in 'tick_nohz_get_idle_calls_cpu'
>> kernel/time/tick-sched.c:1539: warning: Function parameter or member 'mode' not described in 'tick_setup_sched_timer'
vim +1539 kernel/time/tick-sched.c
62cf20b32aee4a Thomas Gleixner 2012-05-25 1533
de667c3b095eed Peng Liu 2023-11-27 1534 #if defined CONFIG_NO_HZ_COMMON || defined CONFIG_HIGH_RES_TIMERS
79bf2bb335b85d Thomas Gleixner 2007-02-16 1535 /**
79bf2bb335b85d Thomas Gleixner 2007-02-16 1536 * tick_setup_sched_timer - setup the tick emulation timer
79bf2bb335b85d Thomas Gleixner 2007-02-16 1537 */
de667c3b095eed Peng Liu 2023-11-27 1538 void tick_setup_sched_timer(int mode)
79bf2bb335b85d Thomas Gleixner 2007-02-16 @1539 {
22127e93c587af Christoph Lameter 2014-08-17 1540 struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched);
79bf2bb335b85d Thomas Gleixner 2007-02-16 1541 ktime_t now = ktime_get();
79bf2bb335b85d Thomas Gleixner 2007-02-16 1542
6c774377359923 Ingo Molnar 2023-09-28 1543 /* Emulate tick processing via per-CPU hrtimers: */
902a9f9c509053 Sebastian Andrzej Siewior 2019-07-26 1544 hrtimer_init(&ts->sched_timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS_HARD);
de667c3b095eed Peng Liu 2023-11-27 1545 if (mode == NOHZ_MODE_HIGHRES)
dba428a678c726 Frederic Weisbecker 2023-09-12 1546 ts->sched_timer.function = tick_nohz_highres_handler;
79bf2bb335b85d Thomas Gleixner 2007-02-16 1547
0de7611a1031f2 Ingo Molnar 2016-07-01 1548 /* Get the next period (per-CPU) */
cc584b213f252b Arjan van de Ven 2008-09-01 1549 hrtimer_set_expires(&ts->sched_timer, tick_init_jiffy_update());
79bf2bb335b85d Thomas Gleixner 2007-02-16 1550
6c774377359923 Ingo Molnar 2023-09-28 1551 /* Offset the tick to avert 'jiffies_lock' contention. */
5307c9556bc17e Mike Galbraith 2012-05-08 1552 if (sched_skew_tick) {
b9965449164299 Thomas Gleixner 2020-11-17 1553 u64 offset = TICK_NSEC >> 1;
5307c9556bc17e Mike Galbraith 2012-05-08 1554 do_div(offset, num_possible_cpus());
5307c9556bc17e Mike Galbraith 2012-05-08 1555 offset *= smp_processor_id();
5307c9556bc17e Mike Galbraith 2012-05-08 1556 hrtimer_add_expires_ns(&ts->sched_timer, offset);
5307c9556bc17e Mike Galbraith 2012-05-08 1557 }
5307c9556bc17e Mike Galbraith 2012-05-08 1558
b9965449164299 Thomas Gleixner 2020-11-17 1559 hrtimer_forward(&ts->sched_timer, now, TICK_NSEC);
de667c3b095eed Peng Liu 2023-11-27 1560 if (mode == NOHZ_MODE_HIGHRES)
902a9f9c509053 Sebastian Andrzej Siewior 2019-07-26 1561 hrtimer_start_expires(&ts->sched_timer, HRTIMER_MODE_ABS_PINNED_HARD);
de667c3b095eed Peng Liu 2023-11-27 1562 else
de667c3b095eed Peng Liu 2023-11-27 1563 tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1);
de667c3b095eed Peng Liu 2023-11-27 1564 tick_nohz_activate(ts, mode);
79bf2bb335b85d Thomas Gleixner 2007-02-16 1565 }
3c4fbe5e01d7e5 Miao Xie 2008-08-20 1566 #endif /* HIGH_RES_TIMERS */
79bf2bb335b85d Thomas Gleixner 2007-02-16 1567
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki